stm32cube: get rid of the HAL Legacy definitions header#321
Draft
mathieuchopstm wants to merge 1 commit intozephyrproject-rtos:mainfrom
Draft
stm32cube: get rid of the HAL Legacy definitions header#321mathieuchopstm wants to merge 1 commit intozephyrproject-rtos:mainfrom
mathieuchopstm wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
mathieuchopstm
force-pushed
the
remove_hal_legacy_header
branch
2 times, most recently
from
a21a0d7 to
f0466c7
Compare
mathieuchopstm
force-pushed
the
remove_hal_legacy_header
branch
from
f0466c7 to
f4b6cc1
Compare
Remove the HAL Legacy definitions header from most series using a dummy replacement (shared by all series!) to ensure proper compilation despite the missing file, and update the README of affected series to remove entry documenting patches to the HAL Legacy definitions header. While it at, get rid of all other legacy headers (can_legacy / eth_legacy) which Zephyr never uses. This is purely cosmectic as these headers are only used if the corresponding HAL module is enabled but Zephyr has never enabled (and will never enable!) the CAN_LEGACY or ETH_LEGACY modules. The STM32F7 and STM32U5 series are not modified and will continue to use their current (patched) HAL Legacy definitions header: some drivers have not been updated(!) and require legacy definitions to build... Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
mathieuchopstm
force-pushed
the
remove_hal_legacy_header
branch
from
f4b6cc1 to
5a56062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the HAL Legacy definitions header from all series using a little trick to ensure proper compilation despite the missing file, and update the README of all series to remove mention of patches to the header we are getting rid of.
Also remove the other legacy headers (can_legacy / eth_legacy) which are never used from the Zephyr side. This is however more of a cosmectic patch as these headers are not part of the build (they are only included if the corresponding HAL module is enabled, which is not the case in Zephyr).